Implement Docking features #261
Conversation
_ImGuiViewport.dpi_scale, parent_viewport_id, id,draw_data, pos
PlatformRequestMove, PlatformRequestResize, PlatformRequestClose
RenderPlatformWindowsDefault(), FindViewportByID, FindViewportByPlatformHandle
| // [ALPHA] Rarely used / very advanced uses only. Use with SetNextWindowClass() and DockSpace() functions. | ||
| // Important: the content of this class is still highly WIP and likely to change and be refactored | ||
| // before we stabilize Docking features. Please be mindful if using this. | ||
| // Provide hints: | ||
| // - To the platform backend via altered viewport flags (enable/disable OS decoration, OS task bar icons, etc.) | ||
| // - To the platform backend for OS level parent/child relationships of viewport. | ||
| // - To the docking system for various options and filtering. |
There was a problem hiding this comment.
Considering the docking branch is WIP, and this api is alpha, it is very likely to change in the future.
In a case like that, it would make sense (imo) to not include it?
There was a problem hiding this comment.
Yes, I do agree. However many features introduced in the docking branch are in beta and may also change. I am not against mapping alpha/beta functionalities as long as it is properly documented. We can always change and document our interface in a future version as well.
There was a problem hiding this comment.
I agree as well and going to comment it, maybe it will be useful in the next future. BTW, I have added it since it is used by SetNextWindowClass(const ImGuiWindowClass* window_class) explicitly.
|
This PR looks good and has a lot of great progress towards docking. Is there anything preventing it from being merged at this point? |
|
I think the only thing that prevents it right now is a lake of time on my part. Sorry ^^ |
|
No need to apologize, we are all donating our time here so I appreciate any availability you have. But yes, I'm very interested! |
|
I finally took time to merge this PR, I hope it will help some of you to move forward with this docking feature. Thanks a lot for the help! Sorry that it took me so long. I didn't test it intensively, hope it is okay since this branch is still a work in progress. I quickly read the modifications and tested locally that localisation and tests worked fine. If someone see a problem, please let me know. |
No description provided.