8000 Refactor bounds by almarklein · Pull Request #1049 · pygfx/pygfx · GitHub
[go: up one dir, main page]
Skip to content

Refactor bounds #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor bounds #1049

wants to merge 1 commit into from

Conversation

almarklein
Copy link
Member

When working on #1042 I actually was on the way for a bigger refactoring. I trimmed it down to avoid stalling. This PR shows what I was working towards.

This is very experimental and requires much more thoughts and discussions. I don't consider it a priority, so I may pick this back up (much) later.

Also see

Thoughts

  • The radius trick helps get tighter bounds, and prevents them from becoming larges are aabb's get transformed.
  • But it's also more CPU intensive. Its it worth it? Maybe some benchmarks.
  • Maybe make it optional?
  • What do we want a cpu-based picking API to look like?

@Korijn
Copy link
Collaborator
Korijn commented Mar 18, 2025
  • What do we want a cpu-based picking API to look like?

I recommend to review the Three.js API and also their implementation. It's quite straightforward.

Korijn
Korijn reviewed Mar 18, 2025
View reviewed changes
pygfx/objects/_base.py

def get_bounds_local_recursive(self):
"""Get the Bounds, local to this objects space, of itself and all its children."""
# TODO: this replicates get_bounding_box(), but should it not include this local.matrix??
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All bounding geometry should be local - in the space of the geometry buffers. It's much cheaper to transform a ray into this space than to transform bounding geometry into ray space (may or may not be world).

@Korijn
Copy link
Collaborator
Korijn commented Mar 18, 2025

I could maybe take this thing out of your hands, and free up some of your time? I have experience implementing this stuff. Maybe we can call so you can share your vision and ideas.

@almarklein
Copy link
Member Author

I could maybe take this thing out of your hands

I was hoping this'd nerd-snipe you 😉 But no rush from my end.

@almarklein almarklein mentioned this pull request Mar 19, 2025
Closed
@gselzer gselzer mentioned this pull request Jul 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korijn Korijn Korijn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almarklein @Korijn
0