10000 New style io by chfw · Pull Request #18 · pyexcel/pyexcel-ods3 · GitHub
[go: up one dir, main page]

Skip to content

New style io #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Oct 3, 2020
Merged

New style io #18

merged 31 commits into from
Oct 3, 2020

Conversation

chfw
Copy link
Member
@chfw chfw commented Oct 3, 2020

reference: pyexcel/pyexcel-io#80

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

chfw and others added 30 commits August 23, 2017 23:39
@chfw chfw changed the base branch from master to dev October 3, 2020 09:23
@codecov-commenter
Copy link
codecov-commenter commented Oct 3, 2020

Codecov Report

Merging #18 into dev will decrease coverage by 0.26%.
The diff coverage is 99.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #18      +/-   ##
==========================================
- Coverage   97.78%   97.52%   -0.27%     
==========================================
  Files          12       12              
  Lines         633      646      +13     
==========================================
+ Hits          619      630      +11     
- Misses         14       16       +2     
Impacted Files Coverage Δ
tests/test_bug_fixes.py 93.25% <96.15%> (+1.19%) ⬆️
pyexcel_ods3/__init__.py 100.00% <100.00%> (ø)
pyexcel_ods3/odsr.py 98.24% <100.00%> (+1.10%) ⬆️
pyexcel_ods3/odsw.py 98.18% <100.00%> (-1.82%) ⬇️
tests/base.py 97.75% <100.00%> (+0.02%) ⬆️
tests/test_filter.py 100.00% <100.00%> (ø)
tests/test_formatters.py 100.00% <100.00%> (ø)
tests/test_multiline_feature.py 100.00% <100.00%> (ø)
tests/test_multiple_sheets.py 97.23% <100.00%> (-0.53%) ⬇️
tests/test_ods_reader.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0d94f...633d87a. Read the comment docs.

@chfw chfw merged commit 4771a4b into dev Oct 3, 2020
@chfw chfw deleted the new-style-io branch October 3, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0