8000 [MRG] Specify import `dcmread` by paddyroddy · Pull Request #2018 · pydicom/pydicom · GitHub
[go: up one dir, main page]

Skip to content

Conversation

paddyroddy
Copy link
Contributor

Describe the changes

First time user, was very confused reading this tutorial as wasn't sure where dcmread came from.

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Code typed and mypy shows no errors
  • Documentation updated (if relevant)
    • No warnings during build
    • Preview link (CircleCI -> Artifacts -> doc/_build/html/i 8000 ndex.html)
  • Unit tests passing and overall coverage the same or better

Copy link
Member
@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (d61f83a) to head (22242af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2018   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          71       71           
  Lines       12170    12170           
=======================================
  Hits        11948    11948           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrbean-bremen mrbean-bremen merged commit dce5644 into pydicom:main Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0