Don't specify a subdir in mypy CI cli #9416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should test that a simple `mypy` invocation works, because that's what's expected to run locally, and instead move any arguments to config files (I hit this because I'm getting type errors locally, though this doesn't fix them, it eliminates a source of difference)
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Sep 23, 2024
* Don't specify a subdir in mypy CI cli We should test that a simple `mypy` invocation works, because that's what's expected to run locally, and instead move any arguments to config files (I hit this because I'm getting type errors locally, though this doesn't fix them, it eliminates a source of difference)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull requ
304B
est is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should test that a simple
mypyinvocation works, because that's what's expected to run locally, and instead move any arguments to config files(I hit this because I'm getting type errors locally, though this doesn't fix them, it eliminates a source of difference)