10000 Add typing to test_plot.py by Illviljan · Pull Request #8889 · pydata/xarray · GitHub
[go: up one dir, main page]
Skip to content

Add typing to test_plot.py #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 5, 2024
Merged

Add typing to test_plot.py #8889

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7534116
Update pyproject.toml
Illviljan Mar 29, 2024
a980fa2
Update test_plot.py
Illviljan Mar 29, 2024
5222c7e
Update test_plot.py
Illviljan Mar 29, 2024
5886f46
Update test_plot.py
Illviljan Mar 29, 2024
d7e79bb
Update test_plot.py
Illviljan Mar 29, 2024
512f347
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 29, 2024
e467d8d
Update test_plot.py
Illviljan Mar 29, 2024
3879266
Update test_plot.py
Illviljan Mar 29, 2024
7849b9b
Update test_plot.py
Illviljan Mar 29, 2024
54e6320
Update test_plot.py
Illviljan Mar 29, 2024
ef678d2
Update test_plot.py
Illviljan Mar 29, 2024
bb94c74
Update test_plot.py
Illviljan Mar 29, 2024
953e692
Update test_plot.py
Illviljan Mar 29, 2024
04dc84f
Update test_plot.py
Illviljan Mar 29, 2024
0e8695c
Update test_plot.py
Illviljan Mar 29, 2024
729bdad
Update test_plot.py
Illviljan Mar 29, 2024
1bef290
Merge branch 'main' into test_plot_typing
Illviljan Mar 29, 2024
c84ec31
raise ValueError if too many dims are requested
Illviljan Mar 30, 2024
8805da3
Merge branch 'main' into test_plot_typing
Illviljan Mar 30, 2024
6b964c0
Merge branch 'main' into test_plot_typing
Illviljan Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test_plot.py
  • Loading branch information
@Illviljan
Illviljan committed Mar 29, 2024
commit 0e8695c02ec0f72ac01be3204e9c55909a53f11a
4 changes: 2 additions & 2 deletions xarray/tests/test_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def substring_in_axes(substring: str, ax: mpl.axes.Axes) -> bool:
"""
Return True if a substring is found anywhere in an axes
"""
alltxt: set[str] = {t.get_text() for t in ax.findobj(mpl.text.Text)}
alltxt: set[str] = {t.get_text() for t in ax.findobj(mpl.text.Text)} # type: ignore[attr-defined] # mpl error?
for txt in alltxt:
if substring in txt:
return True
Expand Down Expand Up @@ -2522,7 +2522,7 @@ def test_default_labels(self) -> None:

# Leftmost column should have array name
for ax in g.axs[:, 0]:
assert substring_in_axes(self.darray.name, ax)
assert substring_in_axes(str(self.darray.name), ax)

def test_test_empty_cell(self) -> None:
g = (
Expand Down
0