10000 don't use `issubdtype` to check for integer dtypes in `polyval` by Ravenin7 · Pull Request #7619 · pydata/xarray · GitHub
[go: up one dir, main page]
Skip to content

don't use issubdtype to check for integer dtypes in polyval #7619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 22, 2023
Merged

don't use issubdtype to check for integer dtypes in polyval #7619

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ecace84
Fixed unneeded ValueError
Ravenin7 Mar 13, 2023
d4b845c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 13, 2023
fb27a96
Fixed unneeded ValueError
Ravenin7 Mar 13, 2023
87a82a2
Merge
Ravenin7 Mar 13, 2023
8d46c20
Revert "Merge"
dcherian Mar 15, 2023
eb73a8c
Merge branch 'main' into Ravenin7-FixIssue-1
TomNicholas Mar 15, 2023
76ea8bc
Merge remote-tracking branch 'upstream/main' into Ravenin7-FixIssue-1
headtr1ck Mar 22, 2023
e79d31d
add to whats-new
headtr1ck Mar 22, 2023
dfad7a5
add tests
headtr1ck Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed unneeded ValueError
  • Loading branch information
@Ravenin7
Ravenin7 committed Mar 13, 2023
commit ecace84530eb8e2ff1d67a70a57ee7b0e85294d5
2 changes: 1 addition & 1 deletion xarray/core/computation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1968,7 +1968,7 @@ def polyval(
raise ValueError(
f"Dimension `{degree_dim}` should be a coordinate variable with labels."
)
if not np.issubdtype(coeffs[degree_dim].dtype, int):
if coeffs[degree_dim].dtype.kind not in 'i':
raise ValueError(
f"Dimension `{degree_dim}` should be of integer dtype. Received {coeffs[degree_dim].dtype} instead."
)
Expand Down
0