8000 propagate indexes in to_dataset, from_dataset by dcherian · Pull Request #3519 · pydata/xarray · GitHub
[go: up one dir, main page]
Skip to content

propagate indexes in to_dataset, from_dataset #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 22, 2019
Merged

propagate indexes in to_dataset, from_dataset #3519

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
97e44a2
Propagate indexes in _to_dataset, _from_dataset
dcherian Nov 11, 2019
1c9373f
Make Indexes immutable again.
dcherian Nov 12, 2019
3a28951
Fix DataArrayGroupby._combine.
dcherian Nov 13, 2019
b902f97
Don't create indexes by default.
dcherian Nov 13, 2019
10e1f4d
fix to_dataset_Splt
dcherian Nov 13, 2019
433ba71
undo groupby change
dcherian Nov 13, 2019
1bffa83
ccomment
dcherian Nov 13, 2019
bba1840
Update xarray/core/indexes.py
dcherian Nov 13, 2019
aefa5e3
Bad idea to deep copy indexes.
dcherian Nov 17, 2019
747962d
Merge remote-tracking branch 'upstream/master' into indexes/dataarray
dcherian Nov 17, 2019
e97a1b2
Merge branch 'indexes/dataarray' of github.com:dcherian/xarray into i…
dcherian Nov 17, 2019
6ae75c0
remove unnecessary copy_indexes calls.
dcherian Nov 17, 2019
73e8e12
copy_indexes → propagate_indexes
dcherian Nov 22, 2019
d7cab03
more renaming.
dcherian Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
undo groupby change
  • Loading branch information
@dcherian
dcherian committed Nov 13, 2019
commit 433ba711be342cbbe8f004d0c451d60e09cd7a0c
4 changes: 0 additions & 4 deletions xarray/core/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,12 +735,8 @@ def _combine(self, applied, restore_coord_dims=False, shortcut=False):
if shortcut:
coord_var = as_variable(coord)
combined._coords[coord.name] = coord_var
if combined._indexes is not None:
combined._indexes[coord.name] = coord_var.to_index()
else:
combined.coords[coord.name] = coord
if combined._indexes is not None:
combined._indexes[coord.name] = coord.to_index()
combined = self._maybe_restore_empty_groups(combined)
combined = self._maybe_unstack(combined)
return combined
Expand Down
0