8000 Another groupby.reduce bugfix. by dcherian · Pull Request #3403 · pydata/xarray · GitHub
[go: up one dir, main page]
Skip to content

Another groupby.reduce bugfix. #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 25, 2019
Merged

Another groupby.reduce bugfix. #3403

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7f20d4f
Another groupby.reduce bugfix.
dcherian Oct 15, 2019
b1660ec
Add whats-new.
dcherian Oct 15, 2019
bf22695
Use is_scalar instead
dcherian Oct 16, 2019
4ccdc5d
bugfix
dcherian Oct 16, 2019
57ba667
Merge remote-tracking branch 'upstream/master' into fix/groupby-reduc…
dcherian Oct 21, 2019
fe0374b
Merge remote-tracking branch 'upstream/master' into fix/groupby-reduc…
dcherian Oct 22, 2019
cd54383
fix whats-new
dcherian Oct 22, 2019
163bb81
Merge remote-tracking branch 'upstream/master' into fix/groupby-reduc…
dcherian Oct 23, 2019
4d14fca
Merge remote-tracking branch 'upstream/master' into fix/groupby-reduc…
dcherian Oct 24, 2019
228c5c7
Merge remote-tracking branch 'upstream/master' into fix/groupby-reduc…
dcherian Oct 25, 2019
d464997
Update xarray/core/groupby.py
dcherian Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update xarray/core/groupby.py 
Co-Authored-By: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
  • Loading branch information
@dcherian @max-sixty
dcherian and max-sixty authored Oct 25, 2019
commit d464997a55d49d194528505b97eb809e5415c46e
2 changes: 1 addition & 1 deletion xarray/core/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def check_reduce_dims(reduce_dims, dimensions):
reduce_dims = [reduce_dims]
if any([dim not in dimensions for dim in reduce_dims]):
raise ValueError(
"cannot reduce over dimensions %r. expected either xarray.ALL_DIMS to reduce over all dimensions or one or more of %r."
"cannot reduce over dimensions %r. expected either '...' to reduce over all dimensions or one or more of %r."
% (reduce_dims, dimensions)
)

Expand Down
0