8000 Default to phony_dims="access" in h5netcdf-backend by kmuehlbauer · Pull Request #10058 · pydata/xarray · GitHub
[go: up one dir, main page]
Skip to content

Default to phony_dims="access" in h5netcdf-backend #10058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 24, 2025
Merged

Default to phony_dims="access" in h5netcdf-backend #10058

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
707deef
Default to phony_dims="access" in open_datatree for h5ntecdf-backend.…
kmuehlbauer Feb 18, 2025
c8d246a
relocate
kmuehlbauer Feb 18, 2025
46c9394
duplicate as needed in both places
kmuehlbauer Feb 18, 2025
34dced2
ignore warning
kmuehlbauer Feb 18, 2025
ca38e7e
conditionally warn users if phony_dims are found
kmuehlbauer Feb 18, 2025
f4871e3
add test for warning
kmuehlbauer Feb 18, 2025
a448eed
add whats-new.rst entry
kmuehlbauer Feb 18, 2025
c401fdd
remove unneeded assignment to fix typing
kmuehlbauer Feb 18, 2025
c0f9fd4
Update doc/whats-new.rst
kmuehlbauer Feb 18, 2025
e196634
use phony_dims="access" per default also in open_dataset for h5netcdf…
kmuehlbauer Feb 19, 2025
fbd61f7
fix test
kmuehlbauer Feb 19, 2025
82f51e3
Merge branch 'main' into phony_dims_access
kmuehlbauer Feb 19, 2025
6daaa72
fix whats-new.rst
kmuehlbauer Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Default to phony_dims="access" in open_datatree for h5ntecdf-backend.… 
… Warn user about behaviour change.
  • Loading branch information
@kmuehlbauer
kmuehlbauer committed Feb 18, 2025
commit 707deeffc410e930430651aae566aec1c20452f1
11 changes: 11 additions & 0 deletions xarray/backends/h5netcdf_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,17 @@ def open_groups_as_dict(
from xarray.core.treenode import NodePath
from xarray.core.utils import close_on_error

# Keep this message for some versions
# remove and set phony_dims="access" above
if phony_dims is None:
emit_user_level_warning(
"The 'phony_dims' kwarg now defaults to 'access'. "
"Previously 'phony_dims=None' would raise an error. "
"For full netcdf equivalence please use phony_dims='sort'.",
UserWarning,
)
phony_dims = "access"

filename_or_obj = _normalize_path(filename_or_obj)
store = H5NetCDFStore.open(
filename_or_obj,
Expand Down
Loading
0