8000 Fix CoreSchema's workaround by ytoku · Pull Request #543 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]

Skip to content

Fix CoreSchema's workaround #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

ytoku
Copy link
Contributor
@ytoku ytoku commented Apr 11, 2023

Dict[str, Any] is incompatible with concrete schemas.
This patch uses Mapping[str, Any] instead.

close #542

@codspeed-hq
Copy link
codspeed-hq bot commented Apr 11, 2023

CodSpeed Performance Report

Merging #543 ytoku:fix-core-schema-workaround (434a0da) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 97 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@codecov-commenter
Copy link

Codecov Report

Merging #543 (434a0da) into main (ed3a372) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files          93       93           
  Lines       12367    12368    +1     
  Branches       24       24           
=======================================
+ Hits        11713    11714    +1     
  Misses        648      648           
  Partials        6        6           
Impacted Files Coverage Δ
pydantic_core/core_schema.py 96.81% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3a372...434a0da. Read the comment docs.

@samuelcolvin samuelcolvin enabled auto-merge (squash) April 11, 2023 16:04
@samuelcolvin
Copy link
Member

thanks so much.

@samuelcolvin samuelcolvin merged commit b1a5f96 into pydantic:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible type error on CoreSchema by mypy
3 participants
0