fix clippy lints for Rust 1.86 #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
approved these changes
Apr 3, 2025
CodSpeed Performance ReportMerging #1682 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix lints for Rust 1.86
NB use of the
write!(string, ...)macro instead ofstring.push_str(&format!(...))is recommended by clippy because it's more efficient (avoids an intermediate allocation in theformat!()call), and should be infallible just likepush_strbut we have to handle the results because other possible targets forwrite!()(like IO streams) might fail.Because it should never fail, I chose to just
.expect()these.Related issue number
N/A
Checklist
pydantic-core(except for expected changes)