Fix enum strict JSON validation when validators are present #1632
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1632 will not alter performanceComparing Summary
|
davidhewitt
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Thanks!
I think the ideal solution I would like to see is for what types are accepted in each of JSON / Python logic to be decided purely based on the InputType and not at all by the physical input value. But I think this would be a large-ish refactor, so it's a future idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Same as #1080. While this addresses pydantic/pydantic#11070, the issue happens in many places, as reported in pydantic/pydantic#9204. The core issue is that before/wrap validators transform the input into the Python mode. This is a a though issue to address, I don't know if it's really possible to fix it properly without making breaking changes and/or tradeoffs.
Related issue number
Fixes pydantic/pydantic#11070.
Checklist
pydantic-core(except for expected changes)