Handle the case where OpenAI ChatCompletion created is None #1764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenAI spec defines this as required, but other OpenAI-compatible providers (like OpenRouter) may not populate it on all responses. This adds code to handle the case where the field is None. Fixes pydantic#1746
|
Just tested this locally with this branch, using the code from the issue, and I saw it successfully get a response from OpenRouter |
|
@wdhorton Thanks! Can you please have a look at the failing coverage check? |
|
Please check https://github.com/pydantic/pydantic-ai/pull/1778/files#r2097604759. I've added a real test case for it, and it actually didn't fail. How can I reproduce this? |
|
@wdhorton I'm closing this PR as it's been a few months with no response; if you're still running into this issue and interested in implementing this feel free to reopen it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAI spec defines this as required, but other OpenAI-compatible providers (like OpenRouter) may not populate it on all responses. This adds code to handle the case where the field is None.
Also added a test case that covers this scenario.
Fixes #1746