8000 Fix _field_name_for_signature docstring by s-rigaud · Pull Request #9958 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@s-rigaud
Copy link
Contributor

Read the doctring after the changes made by this PR, seems to be wrong 🤔

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 24, 2024
@sydney-runkle
Copy link
Contributor

To clarify - the PR didn't change the behavior, but I agree, the docstring should be fixed.

@sydney-runkle sydney-runkle enabled auto-merge (squash) July 24, 2024 18:35
@sydney-runkle sydney-runkle added relnotes-ignore Omit this PR from the release notes. and removed relnotes-fix Used for bugfixes. labels Jul 24, 2024
@codspeed-hq
Copy link
codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #9958 will not alter performance

Comparing s-rigaud:main (d145766) with main (9de2c25)

Summary

✅ 14 untouched benchmarks

@sydney-runkle sydney-runkle merged commit 630cc56 into pydantic:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-ignore Omit this PR from the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0