Add Config.val_json_bytes
#9770
Conversation
CodSpeed Performance ReportMerging #9770 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Looks great! You can use a specific xfail reason argument instead of a comment above :).
We can go ahead and merge this before the corresponding pydantic-core release is out, but could you please provide a screenshot that these tests are passing locally with your branch of pydantic-core?
|
Let's add the changes in #9772 to this PR as well :). Thanks! |
This reverts commit d7b2fd2.
|
Thanks @sydney-runkle, I've updated the xfail reasons and run tests at pydantic/pydantic-core#1308's HEAD: When pydantic/pydantic-core#1308 is incorporated, cherry-picking d7b2fd2 should fix the tests. |
|
Just provided some feedback on pydantic/pydantic-core#1308 (review), thanks for your work here @josh-newman! |
There was a problem hiding this comment.
Awesome work! Just a quick note on the docs
|
Awesome job on getting the tests to pass locally.
I realize, I want to walk this back just a bit - given that this is a new feature and not a bug fix, we'll want to wait for a release. That being said, I can do a minor release of Sorry for the delay on my review, was out for a long holiday. We're super excited about this new feature and your great work! |
|
^^ That being said, I'm not worried about the integration tests failing on the |
To elaborate a bit more, in case others are curious in the future: merging this into main would result in new docs being added to our |
There was a problem hiding this comment.
Looks good, will wait to merge until we pull the pydantic-core changes in 👍
|
Awesome work! Merged into main 🥳 ! |
|
Thanks for the reviews! |
Change Summary
Update
Configwith new option added in pydantic/pydantic-core#1308.Related issue number
None.
Checklist