10BC0 Patch for serialized json schema defaults by sydney-runkle · Pull Request #9624 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Patch for serialized json schema defaults #9624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sydney-runkle merged 3 commits into from
Jun 11, 2024
Merged

Patch for serialized json schema defaults #9624

sydney-runkle merged 3 commits into from
Jun 11, 2024

Conversation

@sydney-runkle
Copy link
Contributor
@sydney-runkle sydney-runkle commented Jun 10, 2024

Fix #9352

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jun 10, 2024
@sydney-runkle sydney-runkle added ready for review relnotes-change Used for changes to existing functionality which don't have a better categorization. and removed relnotes-fix Used for bugfixes. labels Jun 10, 2024
@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Jun 10, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f525f16
Status: ✅  Deploy successful!
Preview URL: https://69a8e6eb.pydantic-docs.pages.dev
Branch Preview URL: https://serializer-json-schema.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
codspeed-hq bot commented Jun 10, 2024 •
8000 edited
Loading

CodSpeed Performance Report

Merging #9624 will not alter performance

Comparing serializer-json-schema (f525f16) with main (13dc7c3)

Summary

✅ 13 untouched benchmarks

adriangb
adriangb approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member
@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems better than nothing, but no guarantee we'll even try to handle anything more complex.

@sydney-runkle
Copy link
Contributor Author
sydney-runkle commented Jun 11, 2024

Going to merge this as is for now, marking this as a change.

Like @adriangb said, I think this is better than our current behavior, but this feature could very well be limited to plain serializers due to the complexity of calling serialization functions during the json schema generation process.

@sydney-runkle sydney-runkle merged commit 811db73 into main Jun 11, 2024
@sydney-runkle sydney-runkle deleted the serializer-json-schema branch June 11, 2024 13:10
@sydney-runkle sydney-runkle mentioned this pull request Jun 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

No one assigned

Labels

ready for review relnotes-change Used for changes to existing functionality which don't have a better categorization.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Annotated PlainSerializer is ignored by model_json_schema for default field

3 participants

@sydney-runkle @adriangb
0