8000 Fixed type hint of validation context by OhioDschungel6 · Pull Request #9508 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@OhioDschungel6
Copy link
Contributor
@OhioDschungel6 OhioDschungel6 commented May 27, 2024

Change Summary

Fixed the type hint of the validation context

Related issue number

fix #9411

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 27, 2024
@OhioDschungel6 OhioDschungel6 mentioned this pull request May 27, 2024
1 task
@codspeed-hq
Copy link
codspeed-hq bot commented May 27, 2024

CodSpeed Performance Report

Merging #9508 will not alter performance

Comparing OhioDschungel6:fix_context_type_hint (48063e6) with main (90d60bd)

Summary

✅ 13 untouched benchmarks

@OhioDschungel6
Copy link
Contributor Author
OhioDschungel6 commented May 27, 2024

please review
Should probably be reviewed in combination with pydantic/pydantic-core#1303

Copy link
Contributor
@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!!

@sydney-runkle sydney-runkle merged commit e874535 into pydantic:main May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type of validation context

3 participants

0