8000 Fix a bug when setting StringConstraint(strict=False) by vbmendes · Pull Request #9476 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Fix a bug when setting StringConstraint(strict=False) #9476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sydney-runkle merged 1 commit into from
May 21, 2024
Merged

Fix a bug when setting StringConstraint(strict=False) #9476

sydney-runkle merged 1 commit into from
May 21, 2024

Conversation

@vbmendes
Copy link
Contributor
@vbmendes vbmendes commented May 21, 2024 •
edited by pydantic-hooky bot
Loading

Change Summary

This PR fixes a bug when setting StringConstraint(strict=False). It was in fact setting the schema to strict=True.

This change was initiated as a test code coverage improvement, but while creating the test, I spotted this bug.

Related issue number

Contributes to #7656 .

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @Kludex

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 21, 2024
@codspeed-hq
Copy link
codspeed-hq bot commented May 21, 2024

CodSpeed Performance Report

Merging #9476 will not alter performance

Comparing vbmendes:increase_types_test_coverage (5f941ab) with main (6820879)

Summary

✅ 13 untouched benchmarks

@vbmendes
Copy link
Contributor Author
vbmendes commented May 21, 2024

please review

sydney-runkle
sydney-runkle approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor
@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@sydney-runkle sydney-runkle merged commit c488508 into pydantic:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Kludex Kludex

Labels

ready for review relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vbmendes @sydney-runkle @Kludex
0