8000 Remove contradicting comment in docstring of `BaseModel.__get_pydantic_core_schema__` by candleindark · Pull Request #9448 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Remove contradicting comment in docstring of BaseModel.__get_pydantic_core_schema__ #9448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sydney-runkle merged 1 commit into from
May 17, 2024
Merged

Remove contradicting comment in docstring of BaseModel.__get_pydantic_core_schema__ #9448

sydney-runkle merged 1 commit into from
May 17, 2024

Conversation

@candleindark
Copy link
Contributor
@candleindark candleindark commented May 17, 2024 •
edited
Loading

Change Summary

This PR made a minor correction in the docstring of BaseModel.__get_pydantic_core_schema__. The commit message in this PR provides the reason for the change.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@candleindark
Remove contradicting comment in BaseModel.__get_pydantic_core_schema__
dceda5d 
The removed comment is incorrect for this is
for core schema generation not for JSON schema generation.
It is also not needed for the following sentence provides
the needed info
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 17, 2024
@codspeed-hq
Copy link
codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #9448 will not alter performance

Comparing candleindark:minor-typo (dceda5d) with main (2511312)

Summary

✅ 13 untouched benchmarks

@sydney-runkle sydney-runkle added relnotes-ignore Omit this PR from the release notes. and removed relnotes-fix Used for bugfixes. labels May 17, 2024
sydney-runkle
sydney-runkle approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor
@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@sydney-runkle sydney-runkle merged commit 15b82a9 into pydantic:main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

relnotes-ignore Omit this PR from the release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@candleindark @sydney-runkle
0