8000 rename allow_population_by_alias -> allow_population_by_field_name by samuelcolvin · Pull Request #875 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

rename allow_population_by_alias -> allow_population_by_field_name #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samuelcolvin merged 4 commits into from
Oct 7, 2019
Merged

rename allow_population_by_alias -> allow_population_by_field_name #875

samuelcolvin merged 4 commits into from
Oct 7, 2019

Conversation

@samuelcolvin
Copy link
Member
@samuelcolvin samuelcolvin commented Oct 7, 2019 •
edited
Loading

Related issue number

fix #585

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@samuelcolvin samuelcolvin mentioned this pull request Oct 7, 2019
Merged
5 tasks
@codecov
Copy link
codecov bot commented Oct 7, 2019 •
edited
Loading

Codecov Report

Merging #875 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #875   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2716   2716           
  Branches      518    518           
=====================================
  Hits         2716   2716

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33b7d52...a293ad1. Read the comment docs.

@samuelcolvin samuelcolvin requested a review from dmontagu October 7, 2019 17:09
@dmontagu
Copy link
Contributor
dmontagu commented Oct 7, 2019

Looks good to me!

Out of curiosity -- do you have a timeline in mind for when the "deprecated" warning will become an error?

@samuelcolvin
Copy link
Member Author
samuelcolvin commented Oct 7, 2019

Out of curiosity -- do you have a timeline in mind for when the "deprecated" warning will become an error?

Not really, I didn't really want to add them to v1, but @tiangolo asked me to include them.

Perhaps 4 months or v1.2 whichever takes longer?

@samuelcolvin samuelcolvin merged commit ae34a6a into master Oct 7, 2019
@samuelcolvin samuelcolvin deleted the allow-pop-by-name branch October 7, 2019 17:40
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this pull request Jan 17, 2020
@samuelcolvin @andreshndz
rename allow_population_by_alias -> allow_population_by_field_name (p…
6ac6124 
…ydantic#875)

* rename allow_population_by_alias -> allow_population_by_field_name, fix pydantic#585

* add change

* tweak PR template ☣️

* tweak Makefile
alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
@art049
Bump pytest-codspeed to v2.1.0 (pydantic#875)
e4f418b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request -- no-alias constructor

3 participants

@samuelcolvin @dmontagu
0