PaymentCardNumber type #790
Conversation
|
@samuelcolvin How does the code look to you? |
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 2889 2972 +83
Branches 568 578 +10
=====================================
+ Hits 2889 2972 +83
Continue to review full report at Codecov.
|
|
@dmontagu thanks for the help! |
There was a problem hiding this comment.
In general looks good, a few things to fix and please add docs.
changes/790-matin.rst
Outdated
| @@ -0,0 +1 @@ | |||
| add the `PaymentCardNumber` type No newline at end of file | |||
There was a problem hiding this comment.
| add the `PaymentCardNumber` type | |
| add the ``PaymentCardNumber`` type |
This is rst :-)
There was a problem hiding this comment.
This still needs changing.
There was a problem hiding this comment.
Just a few more small things, sorry to be a pedant.
|
oh, and conflicts. |
changes/790-matin.rst
Outdated
| @@ -0,0 +1 @@ | |||
| add the `PaymentCardNumber` type No newline at end of file | |||
There was a problem hiding this comment.
This still needs changing.
|
Awesome. Thank you. |
Change Summary
Validation of payment card numbers.
Related issue number
closes #788
Checklist
changes/<pull request or issue id>-<github username>.rstfile added describing change(see changes/README.md for details)