Cache invalid CoreSchema discovery #7535
Merged
+77
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
876a058
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bcc87d5a.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://cache-invalid-schemas.pydantic-docs2.pages.dev |
Member
Author
|
please review |
davidhewitt
reviewed
Sep 21, 2023
pydantic/_internal/_core_utils.py
Outdated
Comment on lines
137
to
139
| def define_expected_missing_refs( | ||
| schema: core_schema.CoreSchema, allowed_missing_refs: set[str] | ||
| ) -> core_schema.CoreSchema: | ||
| ) -> tuple[core_schema.CoreSchema, bool]: |
Contributor
There was a problem hiding this comment.
Potentially document or comment what the bool is here, I had to look at the callsite.
One option to avoid bool (and intermediate tuple, if you care about micro-optimizing) is to return core_schema.CoreSchema | None and return None in the case when there are no missing refs.
| ] = self._needs_apply_discriminated_union | ||
| metadata = schema.setdefault('metadata', {}) | ||
| metadata[NEEDS_APPLY_DISCRIMINATED_UNION_METADATA_KEY] = self._needs_apply_discriminated_union | ||
| metadata['invalid'] = self._has_invalid_schema |
Contributor
There was a problem hiding this comment.
Should 'invalid' maybe also become a constant?
39f1ae6 to
876a058
Compare
davidhewitt
approved these changes
Sep 21, 2023
This was referenced Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected Reviewer: @davidhewitt