8000 Revert "Fix default port for mongosrv DSNs (#6827)" by Kludex · Pull Request #7116 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Revert "Fix default port for mongosrv DSNs (#6827)" #7116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kludex merged 2 commits into from
Aug 14, 2023
Merged

Revert "Fix default port for mongosrv DSNs (#6827)" #7116

Kludex merged 2 commits into from
Aug 14, 2023

Conversation

@Kludex
Copy link
Member
@Kludex Kludex commented Aug 14, 2023 •
edited
Loading

Since we are reverting that PR, the idea is that we recommend doing the following for #6774:

from typing import Annotated

from pydantic.networks import UrlConstraints
from pydantic_core import MultiHostUrl

MongoSRVDsn = Annotated[MultiHostUrl, UrlConstraints(allowed_schemes=['mongodb+srv'])]

Related issue number

Notes

@dmontagu mentioned that we should keep the tests that were added. So I'll add on the next commit... Added.

Selected Reviewer: @davidhewitt

@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Aug 14, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a815afc
Status: ✅  Deploy successful!
Preview URL: https://114fd 8000 311.pydantic-docs2.pages.dev
Branch Preview URL: https://revert-union-mongodsn-2.pydantic-docs2.pages.dev

View logs

@Kludex Kludex requested a review from dmontagu August 14, 2023 13:04
@Kludex
Copy link
Member Author
Kludex commented Aug 14, 2023

please review

@Kludex Kludex merged commit 0e6cb3e into main Aug 14, 2023
@Kludex Kludex deleted the revert-union-mongodsn-2 branch August 14, 2023 15:28
@Kludex Kludex mentioned this pull request Aug 23, 2023
Closed
@hudrazine hudrazine mentioned this pull request Sep 5, 2023
Closed
1 task
@kloczek kloczek mentioned this pull request Nov 14, 2023
Closed
1 task
@kikones34
Copy link
kikones34 commented May 14, 2025

What was the reasoning for this reversion? Without the fix, the MongoDsn validator produces invalid mongo URIs when given a mongo+srv URI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

@davidhewitt davidhewitt

@dmontagu dmontagu

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MongoDsn.build gives AttributeError

5 participants

@Kludex @kikones34 @dmontagu @davidhewitt
0