8000 Add test for v1/v2 Annotated discrepancy by carlbordum · Pull Request #6926 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Add test for v1/v2 Annotated discrepancy #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmontagu merged 1 commit into from
Jul 28, 2023
Merged

Add test for v1/v2 Annotated discrepancy #6926

dmontagu merged 1 commit into from
Jul 28, 2023

Conversation

@carlbordum
Copy link
Contributor
@carlbordum carlbordum commented Jul 28, 2023

It makes sense that model_dump only dumps the actual fields on the model. This test is here to ensure the v1 behavior isn't accidentally introduced again.

@dmontagu
Copy link
Contributor
dmontagu commented Jul 28, 2023

Thanks for the contribution

@dmontagu dmontagu merged commit e8091c4 into pydantic:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlbordum @dmontagu
0