Fix recursion error in json schema generation #6720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
please review cc @dmontagu |
Member
8000
Author
|
@commonism any concerns with this? |
Deploying with
|
| Latest commit: |
07ede88
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://adec97b4.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://deepcopy-core-schema.pydantic-docs2.pages.dev |
Kludex
approved these changes
Jul 17, 2023
dmontagu
reviewed
Jul 17, 2023
Contributor
There was a problem hiding this comment.
I think this makes sense, though @adriangb and I both agree that there is probably a better fix out there.
Probably the best way to fix it would be to generate the JSON schema more fully-independently of the core schema, rather than storing JSON-modification functions on the core schema. Or at least rework the core schema generation so that there is less mutability. But this works now.
Contributor
|
@adriangb amazing thank you for the quick fix! I tested this branch against some of our code which failed previously with random RecursionErrors and now it works with this branch changes |
Contributor
No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6708
Selected Reviewer: @Kludex