8000 Fix alias_generator and field config conflict by Bobronium · Pull Request #658 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Fix alias_generator and field config conflict #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samuelcolvin merged 6 commits into from
Jul 24, 2019
Merged

Fix alias_generator and field config conflict #658

samuelcolvin merged 6 commits into from
Jul 24, 2019

Conversation

@Bobronium
Copy link
Contributor
@Bobronium Bobronium commented Jul 13, 2019 •
edited
Loading

Change Summary

alias_generator will work if field has extra values in schema, but no 'alias' specified

Related issue number

#645

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

@codecov
Copy link
codecov bot commented Jul 13, 2019 •
edited
Loading

Codecov Report

Merging #658 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #658   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2712   2712           
  Branches      537    537           
=====================================
  Hits         2712   2712

@Bobronium
Copy link
Contributor Author
Bobronium commented Jul 13, 2019

@gmetzker, check this out please :)

samuelcolvin
samuelcolvin approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member
@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just rebase and update HISTORY I'm afraid (sorry, will move to towncrier or similar soon).

@gmetzker
Copy link
gmetzker commented Jul 18, 2019

@gmetzker, check this out please :)

I tried your branch and it indeed fixed the issue. Thx @MrMrRobat

@Bobronium
Copy link
Contributor Author
Bobronium commented Jul 19, 2019

@samuelcolvin, I gues we ready for merge!

@samuelcolvin samuelcolvin merged commit 1b4c1a8 into pydantic:master Jul 24, 2019
alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
@davidhewitt
update to PyO3 0.19.0 (pydantic#658)
e7108e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelcolvin samuelcolvin samuelcolvin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bobronium @gmetzker @samuelcolvin
0