Fix forward ref in generic #6511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6503 skip change file check
Member
Author
|
please review |
Deploying with
|
| Latest commit: |
b885eac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c930025c.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-forward-ref-in-generic.pydantic-docs2.pages.dev |
dmontagu
approved these changes
Jul 7, 2023
Contributor
There was a problem hiding this comment.
LGTM, just see the suggestions about the tests
| Foo = module.Foo | ||
| Bar = module.Bar | ||
|
|
||
| assert Foo(x={Bar: Bar}).x[Bar] is Bar |
Contributor
There was a problem hiding this comment.
Suggested change
| assert Foo(x={Bar: Bar}).x[Bar] is Bar | |
| assert Foo(x={Bar: Bar}).x[Bar] is Bar | |
| def test_forward_ref_in_generic_separate_modules(create_module: Any) -> None: | |
| """https://github.com/pydantic/pydantic/issues/6503""" | |
| @create_module | |
| def module_1(): | |
| import typing as tp | |
| from pydantic import BaseModel | |
| class Foo(BaseModel): | |
| x: tp.Dict['tp.Type[Bar]', tp.Type['Bar']] | |
| @create_module | |
| def module_2(): | |
| from pydantic import BaseModel | |
| class Bar(BaseModel): | |
| pass | |
| Foo = module_1.Foo | |
| Bar = module_2.Bar | |
| Foo.model_rebuild(_types_namespace={'tp': typing, 'Bar': Bar}) | |
| assert Foo(x={Bar: Bar}).x[Bar] is Bar |
(Also need to add import typing at the top of the file.)
This test makes sure it also works when the types aren't in the same module. I think it's worth adding but defer to you.
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6503
skip change file check
Selected Reviewer: @samuelcolvin