8000 Add more types to conversion table by hramezani · Pull Request #6005 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Add more types to conversion table #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hramezani merged 2 commits into from
Jun 6, 2023
Merged

Add more types to conversion table #6005

hramezani merged 2 commits into from
Jun 6, 2023

Conversation

@hramezani
Copy link
Member
@hramezani hramezani commented Jun 5, 2023 •
edited by pydantic-hooky bot
Loading

Closes #5363

Selected Reviewer: @Kludex

@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Jun 5, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b6ba899
Status: ✅  Deploy successful!
Preview URL: https://fa22259f.pydantic-docs2.pages.dev
Branch Preview URL: https://complete-conversion-table.pydantic-docs2.pages.dev

View logs

@hramezani hramezani force-pushed the complete_conversion_table branch from dc043bc to 0299082 Compare June 5, 2023 15:47
@hramezani
Copy link
Member Author
hramezani commented Jun 5, 2023

please review

@Kludex
Copy link
Member
Kludex commented Jun 5, 2023

I'll take some hours to review this, fyi

@hramezani
Copy link
Member Author
hramezani commented Jun 5, 2023

I'll take some hours to review this, fyi

No worries. It takes me hours to add them :)

idryzhov
idryzhov reviewed Jun 5, 2023
View reviewed changes
8000 Copy link
@idryzhov idryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments on IP types.

@hramezani
Copy link
Member Author
hramezani commented Jun 5, 2023

A couple of comments on IP types.

Thanks @idryzhov. just fixed them

Kludex
Kludex approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member
@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review carefully.

@hramezani hramezani merged commit aa5d92a into main Jun 6, 2023
@hramezani hramezani deleted the complete_conversion_table branch June 6, 2023 12:29
Sign up for free to join this conversation on Git 7E12 Hub. Already have an account? Sign in to comment

Reviewers

@Kludex Kludex Kludex approved these changes

+1 more reviewer

@idryzhov idryzhov idryzhov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Kludex Kludex

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

V2 docs: Complete conversion table

4 participants

@hramezani @Kludex @idryzhov
0