Improve test coverage for pydantic.type_adapter #5930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c49276e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d191e80.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://type-adapter-test.pydantic-docs2.pages.dev |
Member
Author
|
please review |
1705cf8 to
9c1c47a
Compare
hramezani
commented
May 30, 2023
pydantic/type_adapter.py
Outdated
| json_schema: dict[str, Any] = {} | ||
| if definitions: | ||
| json_schema['$defs'] = definitions | ||
| json_schema['$defs'] = definitions |
Member
Author
There was a problem hiding this comment.
Seems the if definitions condition is always True. So, I did this change to make the coverage 100%
Member
There was a problem hiding this comment.
You need t 8000 o readd it... 👀
from pydantic.type_adapter import TypeAdapter
_, top_level_schema = TypeAdapter.json_schemas(
[(int, 'validation', TypeAdapter(int))],
ref_template='#/components/schemas/{model}',
)
print(top_level_schema)
# {}
Member
Author
There was a problem hiding this comment.
Yeah, you are right.
I've made a test from your example 😃
9c1c47a to
65a9bb1
Compare
Member
|
please update |
Kludex
approved these changes
May 31, 2023
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected Reviewer: @Kludex