8000 Fix mypy plugin for 1.4.0 by cdce8p · Pull Request #5927 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Fix mypy plugin for 1.4.0 #5927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmontagu merged 2 commits into from
May 30, 2023
Merged

Fix mypy plugin for 1.4.0 #5927

dmontagu merged 2 commits into from
May 30, 2023

Conversation

@cdce8p
Copy link
Contributor
@cdce8p cdce8p commented May 30, 2023 •
edited by pydantic-hooky bot
Loading

Change Summary

The next mypy release (1.4.0) will add a new required argument default for TypeVarType and TypeVarExpr (in preparation for PEP 696 support).

I'll open a custom cherry-pick PR next as this won't backport cleanly.

python/mypy#14872

Related issue number

--

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @hramezani

@cdce8p cdce8p mentioned this pull request May 30, 2023
Merged
5 tasks
@cdce8p
Copy link
Contributor Author
cdce8p commented May 30, 2023

please review

@cdce8p
Copy link
Contributor Author
cdce8p commented May 30, 2023

/CC: @dmontagu

hramezani
hramezani reviewed May 30, 2023
View reviewed changes
changes/5927-cdce8p.md Outdated
@@ -0,0 +1 @@
Fix mypy plugin for v1.4.0
Copy link
Member
@hramezani hramezani May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed for the main branch for now

@hramezani
Copy link
Member
hramezani commented May 30, 2023

Thanks @cdce8p. I left a comment. other than that LGTM

please update

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels May 30, 2023
@pydantic-hooky pydantic-hooky bot assigned cdce8p and unassigned hramezani May 30, 2023
@cdce8p
Copy link
Contributor Author
cdce8p commented May 30, 2023

This file is not needed for the main branch for now

Done. Removed it.

please review

@pydantic-hooky pydantic-hooky bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels May 30, 2023
@pydantic-hooky pydantic-hooky bot assigned hramezani and unassigned cdce8p May 30, 2023
@hramezani
Copy link
Member
hramezani commented May 30, 2023

Thanks @cdce8p

Let's wait for @dmontagu

@dmontagu dmontagu merged commit 60122ef into pydantic:main May 30, 2023
@cdce8p cdce8p deleted the fix-mypy branch May 30, 2023 13:34
adriangb pushed a commit that referenced this pull request Jun 1, 2023
@cdce8p
[cherry-pick] Fix mypy plugin for 1.4.0 (#5927) (#5928)
ca10302
@VincentVanlaer VincentVanlaer mentioned this pull request Jun 15, 2023
Merged
CheckmkCI pushed a commit to Checkmk/checkmk that referenced this pull request Jun 22, 2023
@spt29
Regenerated Pipfile.lock + associated fixes.
dcde48a 
Note that we need a pydantic version bump because of
pydantic/pydantic#5927.

Change-Id: I0537ca796d5d0b33e3cc4c6b7a5b27745da37ab7
@tanyaaae12 tanyaaae12 mentioned this pull request Apr 25, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

@hramezani hramezani

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdce8p @hramezani @dmontagu
0