8000 Fix some issues with pydantic extra by dmontagu · Pull Request #5810 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@dmontagu
Copy link
Contributor
@dmontagu dmontagu commented May 19, 2023

I discovered some issues while attempting to make __pydantic_private__, so will fix them here.

  • We weren't properly deepcopying __pydantic_extra__ in the deprecated copy method
  • We weren't checking __pydantic_extra__ during equality checks
  • We weren't including __pydantic_extra__ when pickling models

Selected Reviewer: @samuelcolvin

@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented May 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f53fce0
Status: ✅  Deploy successful!
Preview URL: https://7ee38e0d.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-extra-bugs.pydantic-docs2.pages.dev

View logs

@dmontagu
Copy link
Contributor Author

please review

Copy link
Member
@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samuelcolvin samuelcolvin merged commit 11e16a7 into main May 22, 2023
@samuelcolvin samuelcolvin deleted the fix-extra-bugs branch May 22, 2023 11:55
@samuelcolvin
Copy link
Member

great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0