Eliminate the undefined types warning #5754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveal
8000
s hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6516c43
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6113699.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://eliminate-undefined-types-wa.pydantic-docs2.pages.dev |
Contributor
Author
|
On Adrian's suggestion I made it auto-rebuild as well, happy to remove that though if preferred. |
adriangb
approved these changes
May 12, 2023
Contributor
Author
|
please review |
Member
|
Looks good to me since I had suggested auto rebuilding and that’s all you did since last review 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we discussed this some time around the end of pycon.
I think another viable alternative might be just changing the default config value, but I think if there's any doubt we should just remove this config setting and handle things the way we did in v1 where we only error for undefined types when you attempt to instantiate them.
It's pretty annoying to have to change config everywhere there is a forward ref, and also need to do the model rebuild.
(I did this because I started down the path of rebuilding dataclasses and I felt like if we were going to make this change, I wanted to do so before porting the logic to dataclasses.)
Selected Reviewer: @samuelcolvin