8000 Improve usage errors by hramezani · Pull Request #5699 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@hramezani
Copy link
Member
@hramezani hramezani commented May 5, 2023

Selected Reviewer: @samuelcolvin

@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented May 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1fa058
Status: ✅  Deploy successful!
Preview URL: https://2a630dd6.pydantic-docs2.pages.dev
Branch Preview URL: https://usage-error.pydantic-docs2.pages.dev

View logs

TODO
This error is raised when you define a decorator with an invalid field.

## Dataclass not fully defined {#dataclass-not-fully-defined}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not in use after 3543649

@hramezani
Copy link
Member Author

please review

Copy link
Contributor
@tpdorsey tpdorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggested edits to docs.

Copy link
Member
@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, with @tpdorsey's suggestions and conflicts solved.

@samuelcolvin
Copy link
Member

please update.

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels May 5, 2023
@pydantic-hooky pydantic-hooky bot assigned hramezani and unassigned samuelcolvin May 5, 2023
@hramezani
Copy link
Member Author

Thanks @tpdorsey for your suggestion. All addressed.

Please review

@pydantic-hooky pydantic-hooky bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels May 8, 2023
@pydantic-hooky pydantic-hooky bot assigned samuelcolvin and unassigned hramezani May 8, 2023
Copy link
Contributor
@tpdorsey tpdorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggested edits.

hramezani and others added 3 commits May 8, 2023 17:40
Co-authored-by: Terrence Dorsey <terrend@mishu.com>
Co-authored-by: Terrence Dorsey <terrend@mishu.com>
Co-authored-by: Terrence Dorsey <terrend@mishu.com>
@hramezani hramezani merged commit af62829 into main May 8, 2023
@hramezani hramezani deleted the usage_error branch May 8, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0