Fix ForwardRef collection bug #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
8000
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 2178 2178
Branches 434 434
=====================================
Hits 2178 2178 |
samuelcolvin
reviewed
Apr 2, 2019
docs/examples/forward_ref.py
Outdated
| a: int = 123 | ||
| b: Foo = None | ||
| a: int = None | ||
| b: Dict[str, FooType] = {} |
Member
There was a problem hiding this comment.
No need to change the example, unless otherwise required examples should be as simple as possible.
tests/test_py37.py
Outdated
| @skip_not_37 | ||
| def test_self_forward_ref_validation(create_module): | ||
| module = create_module( | ||
| """ |
Member
There was a problem hiding this comment.
If this string is identical to above, please define it once and reuse.
Member
|
otherwise looks good. |
Member
|
great, thank you. |
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix the bug in ForwardRef collection
Related issue number
#439
Checklist
HISTORY.rsthas been updated#<number>@<whomever>