8000 Simple iterables schema generation by nkonin · Pull Request #335 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@nkonin
Copy link
Contributor
@nkonin nkonin commented Dec 27, 2018

Change Summary

schema generation for : list, : tuple and : set annotations.

Related issue number

No

Performance Changes

Not run

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes | It was already in docs, this PR just fix
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • if you're not a regular contributer please include your github username @whatever

@codecov
Copy link
codecov bot commented Dec 27, 2018

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #335   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines        1783   1801   +18     
  Branches      347    350    +3     
=====================================
+ Hits         1783   1801   +18

@samuelcolvin
Copy link
Member

ref #330 and #331.

Copy link
Member
@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM, @tiangolo?

@samuelcolvin samuelcolvin merged commit e28d689 into pydantic:master Dec 27, 2018
@tiangolo
Copy link
Contributor

Awesome! 🎉

alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0