Fix error when using slots with multiple inheritance #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c96433d to
3694339
Compare
Contributor
Author
|
Not sure why the fastapi tests fail but I given the error and my change I don't think they are related. Please review |
3694339 to
437e2c0
Compare
437e2c0 to
491b3c5
Compare
Contributor
Author
|
Rebased to fix unrelated fastapi GHA fail |
PrettyWood
approved these changes
Sep 4, 2021
Collaborator
There was a problem hiding this comment.
Great! Thank you so much 🙏
jpribyl
pushed a commit
to liquet-ai/pydantic
that referenced
this pull request
Oct 7, 2021
* Fix error when using slots with multiple inheritance * typo * typing Co-authored-by: PrettyWood <em.jolibois@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Using PrivateAttr with multiple inheritance does not work because of the use of
__slots__. The current code sets all parent private attrs again on any child thus overwriting the parent slots. Functionally that is not really an issue but it breaks the algorithm which determines if base classes clash with multiple inheritanceRelated issue number
closes #2988
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)