aliases, fix #275, replace #282

pydantic · samuelcolvin · Nov 15, 2018 · Oct 28, 2018 · Nov 15, 2018 · 34da82568f9b012c831eacc1b2ad9f4c2e7d6985
commit 34da82568f9b012c831eacc1b2ad9f4c2e7d6985
diff --git a/pydantic/env_settings.py b/pydantic/env_settings.py
@@ -37,7 +37,7 @@ def _substitute_environ(self):
         """
         d = {}
         for field in self.__fields__.values():
-            if field.alt_alias:
+            if field.has_alias:
                 env_name = field.alias
             else:
                 env_name = self.__config__.env_prefix + field.name.upper()

diff --git a/pydantic/fields.py b/pydantic/fields.py
@@ -62,6 +62,7 @@ class Field:
         'model_config',
         'name',
         'alias',
+        'has_alias',
         '_schema',
         'validate_always',
         'allow_none',
@@ -85,6 +86,7 @@ def __init__(
     ):
 
         self.name: str = name
+        self.has_alias: bool = bool(alias)
         self.alias: str = alias or name
         self.type_: type = type_
         self.class_validators = class_validators or []

diff --git a/tests/test_settings.py b/tests/test_settings.py
@@ -98,3 +98,15 @@ class Settings(BaseSettings):
     env.set('APP_FOOBAR', 'xxx')
     s = Settings()
     assert s.foobar == 'xxx'
+
+
+def test_alias_matches_name(env):
+    class Settings(BaseSettings):
+        foobar: str
+
+        class Config:
+            fields = {'foobar': 'foobar'}
+
+    env.set('foobar', 'xxx')
+    s = Settings()
+    assert s.foobar == 'xxx'