Added StrictBytes type
#2136
Merged
Added StrictBytes type
#2136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion for StrictBytes and ConstrainedBytes
Contributor
Author
|
cc @hhsecond |
Codecov Report
@@ Coverage Diff @@
## master #2136 +/- ##
===========================================
- Coverage 100.00% 99.63% -0.37%
===========================================
Files 21 21
Lines 4093 4121 +28
Branches 823 829 +6
===========================================
+ Hits 4093 4106 +13
- Misses 0 12 +12
- Partials 0 3 +3
Continue to review full report at Codecov.
|
samuelcolvin
approved these changes
Nov 30, 2020
Member
There was a problem hiding this comment.
LGTM, @PrettyWood are you happy with this? If so feel free to merge.
PrettyWood
reviewed
Dec 1, 2020
PrettyWood
approved these changes
Dec 1, 2020
Contributor
Author
|
Thanks for the review @samuelcolvin and @PrettyWood! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added
StrictBytestype which rejects objects which are castable to bytes (ie.int,float,str), but which are not nativelybytestype. All changes are modeled afterStrictStr,StrictInt,StrictFloat, andStrictBooltypes.Added
strictoption toConstrainedBytesclass. Default value of the option (False) respects downstream code continuity. Any initialization or subclass ofConstrianedBytesbehaves identically to prior implementations unless the"strict"option is explicitly set toTrue).Added
strict_bytes_validatorwhich rejects any object which is notUnion[bytes, bytearray]type. Becausebytearrayinstances are just mutable versions ofbytes, we accept both as equivalent nativebytetypes. This is noted explicitly since the builtin bytearray construtor creates objects with the following behavior:Related issue number
n/a
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)