Fix :: Signature generation with extra: allow never uses a field name
#1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3741 3747 +6
Branches 740 742 +2
=========================================
+ Hits 3741 3747 +6
Continue to review full report at Codecov.
|
`extra_data: Dict[str, str]` would generate `extra_data: str` in the signature
|
thanks so much. I made some tweaks to keep the kwarg name from the actual signature if it's provided. |
|
@samuelcolvin Oh yes right my bad... Thanks! |
PrettyWood
added a commit
to PrettyWood/pydantic
that referenced
this pull request
Apr 24, 2020
`data` has been renamed into `extra_data` to be more explicit in pydantic#1420
PrettyWood
added a commit
to PrettyWood/pydantic
that referenced
this pull request
Apr 24, 2020
`data` has been renamed into `extra_data` to be more explicit in pydantic#1420
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When a model was created with
extra: allow, thegenerate_model_signaturewould add thekwargsparameter with namedatacoming fromBaseModel.__init__.This fix makes the name a bit more explicit (
extra_databy default) and adds as many trailing_as needed to be sure the name is available.Related issue number
fix #1418
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)