8000 Make `Secret` covariant by bluenote10 · Pull Request #12008 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Make Secret covariant #12008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Viicos merged 2 commits into from
Jul 1, 2025
Merged

Make Secret covariant #12008

Viicos merged 2 commits into from
Jul 1, 2025
+11 −1

Conversation

@bluenote10
Copy link
Contributor
@bluenote10 bluenote10 commented Jun 23, 2025 •
edited by pydantic-hooky bot
Loading

Change Summary

This PR make Secret covariant.

Related issue number

Closes #12007

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @DouweM

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jun 23, 2025
@codspeed-hq
Copy link
codspeed-hq bot commented Jun 23, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12008 will not alter performance

Comparing bluenote10:make_secret_covariant (e2d0726) with main (c6d9446)

Summary

✅ 46 untouched benchmarks

@bluenote10 bluenote10 force-pushed the make_secret_covariant branch from a275113 to 44ec597 Compare July 1, 2025 07:40
@github-actions
Copy link
Contributor
github-actions bot commented Jul 1, 2025 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@bluenote10
Copy link
Contributor Author
bluenote10 commented Jul 1, 2025

please review

@DouweM
Copy link
Contributor
DouweM commented Jul 1, 2025

@Viicos Seems reasonable to me.

@DouweM DouweM assigned Viicos and unassigned DouweM Jul 1, 2025
@Viicos
Copy link
Member
Viicos commented Jul 1, 2025

Yes makes sense, thanks @bluenote10, this will be released in the next version (2.12).

@Viicos Viicos added relnotes-change Used for changes to existing functionality which don't have a better categorization. and removed ready for review relnotes-fix Used for bugfixes. labels Jul 1, 2025
@Viicos Viicos changed the title make Secret covariant Make Secret covariant Jul 1, 2025
Viicos
Viicos reviewed Jul 1, 2025
View reviewed changes
@Viicos Viicos enabled auto-merge (squash) July 1, 2025 14:29
@Viicos Viicos merged commit 568509c into pydantic:main Jul 1, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

@Viicos Viicos

Labels

relnotes-change Used for changes to existing functionality which don't have a better categorization.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Secret is unnecessarily invariant, can be made covariant

3 participants

@bluenote10 @DouweM @Viicos
0