8000 Rebuild dataclass fields before schema generation by Viicos · Pull Request #11949 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Rebuild dataclass fields before schema generation #11949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Viicos
Copy link
Member
@Viicos Viicos commented Jun 4, 2025

This applying roughly the same logic from #11388 for dataclasses.

Fixes #11947.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added relnotes-fix Used for bugfixes. backport-2.11 Needs backport to 2.11 labels Jun 4, 2025
Copy link
codspeed-hq bot commented Jun 4, 2025

CodSpeed Performance Report

Merging #11949 will not alter performance

Comparing rebuild-dataclass-fields (fc1858d) with main (88c75cd)

Summary

✅ 46 untouched benchmarks

This applying roughly the same logic from #11388
for dataclasses.
@Viicos Viicos force-pushed the rebuild-dataclass-fields branch from 158a17d to fc1858d Compare June 4, 2025 14:30
@Viicos Viicos added the third-party-tests Add this label on a PR to trigger 3rd party tests label Jun 4, 2025
@Viicos Viicos closed this Jun 4, 2025
@Viicos Viicos reopened this Jun 4, 2025
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc1858d
Status: ✅  Deploy successful!
Preview URL: https://3ede4c38.pydantic-docs.pages.dev
Branch Preview URL: https://rebuild-dataclass-fields.pydantic-docs.pages.dev

View logs

Copy link
Contributor
github-actions bot commented Jun 4, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  dataclasses.py 329
  pydantic/_internal
  _fields.py
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.11 Needs backport to 2.11 relnotes-fix Used for bugfixes. third-party-tests Add this label on a PR to trigger 3rd party tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.11.0 fails to resolve forward ref (future annotation)?
1 participant
0