8000 Remove coercion of decimal constraints by Viicos · Pull Request #11772 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@Viicos
Copy link
Member
@Viicos Viicos commented Apr 17, 2025

This is now done in pydantic-core, and wasn't done right as it resulted in some floating point precision errors.

Change Summary

Fixes #11763.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

This is now done in `pydantic-core`, and wasn't done right
as it resulted in some floating point precision errors.
@Viicos Viicos added relnotes-fix Used for bugfixes. backport-2.11 labels Apr 17, 2025
@cloudflare-workers-and-pages
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 48f4de5
Status: ✅  Deploy successful!
Preview URL: https://ed7e6dad.pydantic-docs.pages.dev
Branch Preview URL: https://remove-manual-decimal-coerci.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
codspeed-hq bot commented Apr 17, 2025

CodSpeed Performance Report

Merging #11772 will not alter performance

Comparing remove-manual-decimal-coercion (48f4de5) with main (a3f42a4)

Summary

✅ 46 untouched benchmarks

@github-actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _known_annotated_metadata.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit cc30e6d into main Apr 17, 2025
63 checks passed
@Viicos Viicos deleted the remove-manual-decimal-coercion branch April 17, 2025 16:30
Viicos added a commit that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-integer multiple_of failing on decimal.Decimal after 2.11

3 participants

0