8000 Remove coercion of decimal constraints by Viicos · Pull Request #11772 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Remove coercion of decimal constraints #11772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

Conversation

Viicos
Copy link
Member
@Viicos Viicos commented Apr 17, 2025

This is now done in pydantic-core, and wasn't done right as it resulted in some floating point precision errors.

Change Summary

Fixes #11763.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

This is now done in `pydantic-core`, and wasn't done right
as it resulted in some floating point precision errors.
@Viicos Viicos added relnotes-fix Used for bugfixes. backport-2.11 Needs backport to 2.11 labels Apr 17, 2025
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 48f4de5
Status: ✅  Deploy successful!
Preview URL: https://ed7e6dad.pydantic-docs.pages.dev
Branch Preview URL: https://remove-manual-decimal-coerci.pydantic-docs.pages.dev

View logs

Copy link
codspeed-hq bot commented Apr 17, 2025

CodSpeed Performance Report

Merging #11772 will not alter performance

Comparing remove-manual-decimal-coercion (48f4de5) with main (a3f42a4)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _known_annotated_metadata.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit cc30e6d into main Apr 17, 2025
63 checks passed
@Viicos Viicos deleted the remove-manual-decimal-coercion branch April 17, 2025 16:30
Viicos added a commit that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.11 Needs backport to 2.11 relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-integer multiple_of failing on decimal.Decimal after 2.11
2 participants
0