10BC0 Remove generics cache workaround by Viicos · Pull Request #11755 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@Viicos
Copy link
Member
@Viicos Viicos commented Apr 15, 2025

This results in parameterized classes being different type objects, although they represent the same type.

A new refactor (#11388) was introduced since then and fixes the root issue.

Fixes #11747.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

This results in parameterized classes being different type objects,
although they represent the same type.

A new refactor (#11388)
was introduced since then and fixes the root issue.
@Viicos Viicos added relnotes-fix Used for bugfixes. backport-2.11 labels Apr 15, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly reverting test changes in #10704.

@codspeed-hq
Copy link
codspeed-hq bot commented Apr 15, 2025

CodSpeed Performance Report

Merging #11755 will not alter performance

Comparing remove-caching-generics (95b79f7) with main (72a76ef)

Summary

✅ 46 untouched benchmarks

@github-actions
Copy link
Contributor
github-actions bot commented Apr 15, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor
@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me 👍

6880
@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Apr 15, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 95b79f7
Status: ✅  Deploy successful!
Preview URL: https://5fbc6163.pydantic-docs.pages.dev
Branch Preview URL: https://remove-caching-generics.pydantic-docs.pages.dev

View logs

@Viicos Viicos enabled auto-merge (squash) April 15, 2025 13:43
@Viicos Viicos merged commit 625dd42 into main Apr 15, 2025
59 checks passed
@Viicos Viicos deleted the remove-caching-generics branch April 15, 2025 13:57
Viicos added a commit that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UserWarning: Pydantic serializer warnings >= v2.11.0

3 participants

0