8000 Preserve field description when rebuilding model fields by Viicos · Pull Request #11698 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Preserve field description when rebuilding model fields #11698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

Viicos
Copy link
Member
@Viicos Viicos commented Apr 4, 2025

Change Summary

Fixes #11696, regression in #11388.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added relnotes-fix Used for bugfixes. backport-2.11 Needs backport to 2.11 labels Apr 4, 2025
Copy link
cloudflare-workers-and-pages bot commented Apr 4, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2e8aab
Status: ✅  Deploy successful!
Preview URL: https://63c72518.pydantic-docs.pages.dev
Branch Preview URL: https://rebuild-fields-desc.pydantic-docs.pages.dev

View logs

Copy link
Contributor
github-actions bot commented Apr 4, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _fields.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
codspeed-hq bot commented Apr 4, 2025

CodSpeed Performance Report

Merging #11698 will not alter performance

Comparing rebuild-fields-desc (e2e8aab) with main (bd1f8cf)

Summary

✅ 46 untouched benchmarks

8000

@Viicos Viicos force-pushed the rebuild-fields-desc branch from e7296a2 to e2e8aab Compare April 7, 2025 07:11
@Viicos Viicos merged commit f14b7da into main Apr 8, 2025
62 checks passed
@Viicos Viicos deleted the rebuild-fields-desc branch April 8, 2025 12:08
Viicos added a commit that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.11 Needs backport to 2.11 relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model_rebuild() doesn't respect use_attribute_docstrings
2 participants
0