8000 Do not override `FieldInfo._complete` when using field from parent class by Viicos · Pull Request #11668 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Do not override FieldInfo._complete when using field from parent class #11668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

Viicos
Copy link
Member
@Viicos Viicos commented Apr 1, 2025

Change Summary

Fixes #11663. Regression in #11388.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Apr 1, 2025
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1b6a82d
Status: ✅  Deploy successful!
Preview URL: https://6c975215.pydantic-docs.pages.dev
Branch Preview URL: https://parent-model-fields.pydantic-docs.pages.dev

View logs

@Viicos Viicos added the backport-2.11 Needs backport to 2.11 label Apr 1, 2025
Copy link
codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #11668 will not alter performance

Comparing parent-model-fields (1b6a82d) with main (6c38dc9)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor
github-actions bot commented Apr 1, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _fields.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit 86c5703 into main Apr 2, 2025
63 checks passed
@Viicos Viicos deleted the parent-model-fields branch April 2, 2025 14:51
Viicos added a commit that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.11 Needs backport to 2.11 relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types and default value not resolved correctly in inherited class if ONE of types is forward ref 3887
2 participants
0