8000 Remove `greenlet` development dependency by Viicos · Pull Request #11351 · pydantic/pydantic · GitHub 8000
[go: up one dir, main page]

Skip to content

Conversation

@Viicos
Copy link
Member
@Viicos Viicos commented Jan 28, 2025

Change Summary

It is already required by sqlalchemy (and will not be anymore on sqlalchemy 2.1)

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jan 28, 2025
@cloudflare-workers-and-pages
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6805e76
Status: ✅  Deploy successful!
Preview URL: https://77b2616c.pydantic-docs.pages.dev
Branch Preview URL: https://remove-greenlet.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #11351 will not alter performance

Comparing remove-greenlet (6805e76) with main (5f40fe4)

Summary

✅ 45 untouched benchmarks

@github-actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos merged commit 4722283 into main Jan 28, 2025
56 checks passed
@Viicos Viicos deleted the remove-greenlet branch January 28, 2025 17:13
@Viicos Viicos added relnotes-packaging Used for dependency changes. and removed relnotes-fix Used for bugfixes. labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Assignees

No one assigned

Labels

relnotes-packaging Used for dependency changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0