Properly support type variable defaults #11332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
ec82c47
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a902f4a8.pydantic-docs.pages.dev |
| Branch Preview URL: | https://typevar-defaults.pydantic-docs.pages.dev |
5 tasks
If a type argument isn't provided, use the default value.
80a5666 to
e362df2
Compare
CodSpeed Performance ReportMerging #11332 will not alter performanceComparing Summary
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Generally, looking good! Thanks for tackling this :)
sydney-runkle
approved these changes
Jan 24, 2025
Contributor
There was a problem hiding this comment.
Thanks, it's more clear with the extra comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a type argument isn't provided, use the default value.
Change Summary
Fixes #11270, closes #11297.
Related issue number
Checklist