8000 Do not transform model serializer functions as class methods in the mypy plugin by Viicos · Pull Request #11298 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Do not transform model serializer functions as class methods in the mypy plugin #11298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

Viicos
Copy link
Member
@Viicos Viicos commented Jan 17, 2025

Also format the mypy test code using latest Ruff.

Fixes #10707.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

8000
…ypy plugin

Also format the mypy test code using latest Ruff.
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jan 17, 2025
Copy link
cloudflare-workers-and-pages bot commented Jan 17, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4782617
Status: ✅  Deploy successful!
Preview URL: https://d06fc3f9.pydantic-docs.pages.dev
Branch Preview URL: https://10707.pydantic-docs.pages.dev

View logs

Copy link
codspeed-hq bot commented Jan 17, 2025

CodSpeed Performance Report

Merging #11298 will not alter performance

Comparing 10707 (4782617) with main (1c698d7)

Summary

✅ 45 untouched benchmarks

Copy link
Contributor
github-actions bot commented Jan 17, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageC 8000 overage
(new stmts)
Lines missing
  pydantic
  mypy.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit 6a5b640 into main Jan 22, 2025
56 checks passed
@Viicos Viicos deleted the 10707 branch January 22, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy incorrectly identifies argument of method within a model_serializer as incorrect
2 participants
0