Move deque schema gen to GenerateSchema class
#11239
Merged
+42
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #11239 will not alter performanceComparing Summary
|
Deploying pydantic-docs with
|
| Latest commit: |
34193ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9fb4ec4.pydantic-docs.pages.dev |
| Branch Preview URL: | https://remove-deq-prep-anns.pydantic-docs.pages.dev |
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
|
cc @adriangb, more progress on simplifying logic here :) No need for a review, but wanted to let you know. |
Viicos
approved these changes
Jan 9, 2025
I'm not opposed to allowing metadata access, though this opens a can of worms in terms of consistency with annotation application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #10846
See the description of that PR for more detail.
One consequence here is slightly different behavior for
maxlenbeing set fordequetypes, but I think this is worth the significant simplification in internal logic we see here.max_lengthconstraints are still enforced, but we no longer monkeypatch themaxlenfrommax_lengthon the deque. If users want this, they should write a custom validator.I'll be writing an in depth explanation of changes in the changelog for v2.11 related to this PR sequence.